Skip to content

builds: Push to GHCR in parallel & pull from GHCR in CI #33673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2025
Merged

builds: Push to GHCR in parallel & pull from GHCR in CI #33673

merged 3 commits into from
Oct 24, 2025

Conversation

@def-
Copy link
Contributor

@def- def- commented Sep 22, 2025 •
edited
Loading

Currently experiencing slow Dockerhub pulls

Edit: On my dev server GHCR seems to pull much faster, 5s instead of 16s for an environmentd image.

If this works well we could also consider using it locally.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- force-pushed the pr-push-ghcr branch 6 times, most recently from f60c175 to 7c6a113 Compare September 26, 2025 16:41
@def- def- changed the title builds: Try pushing to GHCR in parallel builds: Try pushing to GHCR in parallel & pull from GHCR in CI Sep 26, 2025
@def-
Copy link
Contributor Author

def- commented Sep 26, 2025 •
edited
Loading

Status: blocked on https://github.com/MaterializeInc/i2/pull/2856
Edit: Unblocked.
TODO: Also for ci-builder.

@def- def- force-pushed the pr-push-ghcr branch 5 times, most recently from f2fa3c8 to 4422a1f Compare September 27, 2025 12:43
@def- def- force-pushed the pr-push-ghcr branch 16 times, most recently from 9d0e665 to 74ee381 Compare October 23, 2025 21:01
@def- def- changed the title builds: Try pushing to GHCR in parallel & pull from GHCR in CI builds: Push to GHCR in parallel & pull from GHCR in CI Oct 23, 2025
@def- def- marked this pull request as ready for review October 23, 2025 21:17
@def- def- requested a review from a team as a code owner October 23, 2025 21:17
@def- def- enabled auto-merge October 24, 2025 08:20
@def- def- merged commit f8c5b36 into MaterializeInc:main Oct 24, 2025
127 checks passed
@def- def- deleted the pr-push-ghcr branch October 24, 2025 08:42
@def- def- mentioned this pull request Oct 30, 2025
Closed
5 tasks
@def- def- added self-managed-backport-v25.1 Needs to be backported into the v25.1 self-managed release self-managed-backport-v25.2 Needs to be backported into the v25.2 self-managed release and removed self-managed-backport-v25.1 Needs to be backported into the v25.1 self-managed release self-managed-backport-v25.2 Needs to be backported into the v25.2 self-managed release labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

@ggevay ggevay Awaiting requested review from ggevay

@SangJunBak SangJunBak Awaiting requested review from SangJunBak

Assignees

No one assigned

Labels

self-managed-backport-v25.1 Needs to be backported into the v25.1 self-managed release self-managed-backport-v25.2 Needs to be backported into the v25.2 self-managed release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@def- @bobbyiliev